Repository navigation
test: give the inbound the headers-sync slot before the stall check - #1216
Merged
Merged
Conversation
Coverage failed p2p_timeout_getaddr_and_keepalive_ping while the test job passed. A tip older than a day has one headers-sync slot. The journey dialed a preferred outbound first, that outbound could win the slot, and a sole preferred peer is not disconnected.
The empty address book already proves an operator onion seednode reaches SOCKS. The 10s fallback wait is pinned by seednode_delay_elapsed without running the node for 12 seconds.
The redial test held a thread until the 8s connect bound. A floor under the production 30s is that bound, so the test still skips a second dial while the first is in flight and redials once the stall times out. SOCKS_CONNECT_TIMEOUT stays 30s and OUTBOUND_CONNECT_TIMEOUT stays 8s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tip older than a day has one headers-sync slot.
p2p_timeout_getaddr_and_keepalive_pingdialed a preferred outbound before the inbound owned that slot. Under coverage the outbound's first writes can win the slot, a sole preferred peer is kept, and the coverage job failed while the test job passed. The inbound now takes the slot first, and the stall check jumps one second past that peer's armed deadline.Two
testjob waits come off in the later commits. The empty address book still proves an operator onion seednode reaches SOCKS. The 10s populated-book fallback stays pinned byseednode_delay_elapsed, without a 12s live run. The redial test still refuses a second dial while a stalled proxy holds the first, then redials after that connect times out. A SOCKS floor under the production 30s is that bound, so the test no longer sits on the 8s base.SOCKS_CONNECT_TIMEOUTstays 30s andOUTBOUND_CONNECT_TIMEOUTstays 8s. The other SOCKS tests complete the handshake. They do not accept and hang on the 30s floor.