Repository navigation
test: count this query's rbtc-tip-flush thread - #1284
Closed
rearden-grok[bot] wants to merge 1 commit into
Closed
rearden-grok[bot] wants to merge 1 commit into
rearden-grok[bot] wants to merge 1 commit into
Conversation
The suite scanned every comm in the process. Under coverage another query still had the barrier thread after this one dropped, so two_ibd_flushes_share_one_named_thread failed while the test job passed.
Contributor
Author
|
The same pin is already on #1217 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage on
e19d0db5(run 40738545456) failedtip_flush::two_ibd_flushes_share_one_named_threadwithleft: 1, right: 0on the post-drop comm count. Thetestjob passed.That assert counts every
rbtc-tip-flushin the process. The query suite runs in one process, so another query's barrier thread is still visible after this query joins its own. The worker now publishes an alive count and its Linux tid, and the test reads those.cargo test --workspace,./scripts/ci-os-smoke.sh, clippy-p rbitcoin-query --all-targets,cargo deny check, and./scripts/ast-grep.shpassed locally.