Dev

.claude/WORKFLOW.md

@@ -41,11 +41,11 @@ main (production-ready)
   │
   └─── dev (integration branch)
         │
-        ├─── feature/ddd-value-objects (task branch)
-        ├─── feature/drag-and-drop (task branch)
-        ├─── feature/bottomsheet-redesign (task branch)
-        ├─── bugfix/bottomsheet-scroll (task branch)
-        └─── ci/ios-workflow (task branch)
+        ├─── feature/ARS-5-3d-model-preview (task branch)
+        ├─── bugfix/ARS-6-gallery-crash (task branch)
+        ├─── fix/ARS-7-camera-controls-symmetry (task branch)
+        ├─── feature/ARS-8-short-description (task branch)
+        └─── bugfix/ARS-9-short-description (task branch)
 ```
 
 ### Branch Types
@@ -78,7 +78,7 @@ main (production-ready)
 │    Agent creates feature branch from 'dev'                   │
 │    git checkout dev                                          │
 │    git pull origin dev                                       │
-│    git checkout -b feature/task-name                         │
+│    git checkout -b feature/ARS-N-task-name                         │
 └───────────────────────┬─────────────────────────────────────┘
                         │
                         ▼
@@ -105,7 +105,7 @@ main (production-ready)
 │    Agent commits and pushes to remote                        │
 │    git add .                                                 │
 │    git commit -m "feat: task description"                    │
-│    git push origin feature/task-name                         │
+│    git push origin feature/ARS-N-task-name                         │
 └───────────────────────┬─────────────────────────────────────┘
                         │
                         ▼
@@ -159,18 +159,18 @@ main (production-ready)
 ### Components
 
 - **type**: Branch type prefix (feature, bugfix, ci, refactor, test)
-- **task-id**: Task ID from SQL database (kebab-case)
+- **task-id**: Task ID from Jira board (ARS-N format, e.g. ARS-5)
 - **short-description**: Optional 2-3 word description
 
 ### Examples
 
 | Task ID | Branch Name | Agent |
 |---------|-------------|-------|
-| `ddd-value-objects` | `refactor/ddd-value-objects` | main-developer-agent |
-| `drag-and-drop` | `feature/drag-and-drop` | android-expert-agent |
-| `bottomsheet-scroll-bug` | `bugfix/bottomsheet-scroll` | bug-fixer-agent |
-| `github-workflow-ios` | `ci/ios-workflow` | ios-expert-agent |
-| `prevent-accidental-tap` | `feature/prevent-accidental-tap` | main-developer-agent |
+| `ARS-5` | `feature/ARS-5-3d-model-preview` | android-expert-agent |
+| `ARS-6` | `bugfix/ARS-6-gallery-crash` | bug-fixer-agent |
+| `ARS-7` | `fix/ARS-7-camera-controls-symmetry` | main-developer-agent |
+| `ARS-8` | `feature/ARS-8-short-description` | main-developer-agent |
+| `ARS-9` | `bugfix/ARS-9-short-description` | bug-fixer-agent |
 
 ### Branch Type Selection Guide
 

composeApp/build.gradle.kts

@@ -7,6 +7,7 @@ plugins {
     alias(libs.plugins.composeMultiplatform)
     alias(libs.plugins.composeCompiler)
     alias(libs.plugins.kotlinSerialization)
+    alias(libs.plugins.kover)
 }
 
 kotlin {
@@ -23,6 +24,8 @@ kotlin {
         iosTarget.binaries.framework {
             baseName = "ComposeApp"
             isStatic = true
+            // Required for ModelPreviewThumbnail.ios.kt: platform.SceneKit.*
+            linkerOpts("-framework", "SceneKit")
         }
     }
 
@@ -35,6 +38,7 @@ kotlin {
             implementation(libs.sceneview)
             implementation(libs.arcore)
             implementation(libs.gson)
+            implementation(libs.koin.android)
         }
         commonMain.dependencies {
             implementation(compose.runtime)
@@ -48,6 +52,8 @@ kotlin {
             implementation(libs.androidx.lifecycle.runtimeCompose)
             implementation(libs.kotlinx.serialization.json)
             implementation(libs.kotlinx.coroutines.core)
+            implementation(libs.koin.core)
+            implementation(libs.koin.compose)
         }
         commonTest.dependencies {
             implementation(libs.kotlin.test)
@@ -88,3 +94,42 @@ dependencies {
     debugImplementation(libs.compose.uiTooling)
 }
 
+koverReport {
+    defaults {
+        html {
+            onCheck = true
+        }
+        xml {
+            onCheck = true
+        }
+    }
+
+    filters {
+        excludes {
+            // Exclude generated code
+            classes("*_Factory", "*_HiltModules*", "Hilt_*", "*BuildConfig")
+            // Exclude Android framework classes
+            packages("*.di", "*.ui.theme")
+            // Exclude Compose generated
+            annotatedBy("androidx.compose.runtime.Composable")
+        }
+    }
+
+    verify {
+        rule {
+            isEnabled = true
+            // Domain layer should have high coverage
+            filters {
+                includes {
+                    packages("com.trendhive.arsample.domain.*")
+                    packages("com.trendhive.arsample.application.*")
+                }
+            }
+            bound {
+                minValue = 80
+                metric = kotlinx.kover.gradle.plugin.dsl.MetricType.LINE
+            }
+        }
+    }
+}
+

composeApp/src/androidMain/AndroidManifest.xml

@@ -5,6 +5,11 @@
     <!-- Camera izni - AR icin zorunlu -->
     <uses-permission android:name="android.permission.CAMERA" />
 
+    <!-- Medya okuma izinleri - Galeri icin -->
+    <uses-permission android:name="android.permission.READ_MEDIA_IMAGES" />
+    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="32" />
+    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="28" />
+
     <!-- AR ozelligi gerektiren cihazlari belirt -->
     <uses-feature
         android:name="android.hardware.camera.ar"

composeApp/src/androidMain/kotlin/com/trendhive/arsample/MainActivity.kt

@@ -5,10 +5,12 @@ import androidx.activity.ComponentActivity
 import androidx.activity.compose.setContent
 import androidx.activity.enableEdgeToEdge
 import androidx.core.splashscreen.SplashScreen.Companion.installSplashScreen
-import com.trendhive.arsample.infrastructure.persistence.local.*
-import com.trendhive.arsample.infrastructure.persistence.repository.*
-import com.trendhive.arsample.application.usecase.*
-import java.io.File
+import com.trendhive.arsample.di.appModules
+import com.trendhive.arsample.di.platformDataSourceModule
+import org.koin.android.ext.koin.androidContext
+import org.koin.android.ext.koin.androidLogger
+import org.koin.core.context.GlobalContext
+import org.koin.core.context.startKoin
 
 class MainActivity : ComponentActivity() {
     override fun onCreate(savedInstanceState: Bundle?) {
@@ -18,36 +20,18 @@ class MainActivity : ComponentActivity() {
         enableEdgeToEdge()
         super.onCreate(savedInstanceState)
 
-        // Simple DI setup for Android
-        val filesDir = applicationContext.filesDir
-        val modelFileStorage = ModelFileStorageImpl(applicationContext, filesDir)
-        val objectLocalDataSource = ARObjectLocalDataSourceImpl(filesDir)
-        val sceneDataStore = ARSceneDataStoreImpl(filesDir)
-
-        val objectRepository = ARObjectRepositoryImpl(objectLocalDataSource, modelFileStorage)
-        val sceneRepository = ARSceneRepositoryImpl(sceneDataStore)
-
-        val importObjectUseCase = ImportObjectUseCase(objectRepository)
-        val getAllObjectsUseCase = GetAllObjectsUseCase(objectRepository)
-        val deleteObjectUseCase = DeleteObjectUseCase(objectRepository)
-        val placeObjectInSceneUseCase = PlaceObjectInSceneUseCase(sceneRepository, objectRepository)
-        val removeObjectFromSceneUseCase = RemoveObjectFromSceneUseCase(sceneRepository)
-        val getSceneUseCase = GetSceneUseCase(sceneRepository)
-        val saveSceneUseCase = SaveSceneUseCase(sceneRepository)
-        val moveObjectUseCase = MoveObjectUseCase(sceneRepository)
+        // Initialize Koin DI only if not already started
+        // This prevents crash on Activity recreation (e.g., configuration change)
+        if (GlobalContext.getOrNull() == null) {
+            startKoin {
+                androidLogger()
+                androidContext(applicationContext)
+                modules(platformDataSourceModule() + appModules)
+            }
+        }
 
         setContent {
-            App(
-                importObjectUseCase = importObjectUseCase,
-                getAllObjectsUseCase = getAllObjectsUseCase,
-                deleteObjectUseCase = deleteObjectUseCase,
-                placeObjectInSceneUseCase = placeObjectInSceneUseCase,
-                removeObjectFromSceneUseCase = removeObjectFromSceneUseCase,
-                getSceneUseCase = getSceneUseCase,
-                saveSceneUseCase = saveSceneUseCase,
-                moveObjectUseCase = moveObjectUseCase,
-                sceneRepository = sceneRepository
-            )
+            App()
         }
     }
 }