Deprecate MoveCurrentDateTimeDefaultInEntityToConstructorRector, drop force_nullable option

[TomasVotruba]

1) Deprecate MoveCurrentDateTimeDefaultInEntityToConstructorRector

The database-level default and the PHP-level default are not interchangeable. The rule moved the default into the constructor, which changes when the value is created — the database default is evaluated on INSERT by the database, the constructor default on object creation by PHP. That is a behavior change the rule cannot verify, and it needs manual care per entity.

 use Doctrine\ORM\Mapping as ORM;

 /**
  * @ORM\Entity()
  */
 class User
 {
     /**
      * @var DateTimeInterface
-     * @ORM\Column(type="datetime", nullable=false, options={"default"="now()"})
+     * @ORM\Column(type="datetime", nullable=false)
      */
-    private $when = 'now()';
+    private $when;
+
+    public function __construct()
+    {
+        $this->when = new \DateTime();
+    }
 }

The rule is removed from the doctrine-code-quality set and now throws on use, like the other deprecated rules.

Its 3 exclusive helper services are removed as well: ValueAssignFactory, ConstructorManipulator, ConstructorAssignPropertyAnalyzer.

2) Drop force_nullable option of TypedPropertyFromToOneRelationTypeRector

We never know how the entity is used — it can always be constructed before the relation is set, so the property must be nullable. The option defaulted to true anyway; the false branch produced a non-nullable typed property that fatals on read before assignment.

 use Doctrine\ORM\Mapping as ORM;

 class SimpleColumn
 {
     /**
      * @ORM\OneToOne(targetEntity="App\Company\Entity\Company")
      * @ORM\JoinColumn(nullable=false)
      */
-    private $company;
+    private ?\App\Company\Entity\Company $company = null;
 }

ToOneRelationPropertyTypeResolver loses the nullable detection it no longer needs.

3) Cleanup

Removed leftover empty test config dir of the already-removed AddReturnDocBlockToCollectionPropertyGetterByToManyAnnotationRector.