Deprecate RemoveEmptyTableAttributeRector - #505
Merged
Conversation
Removing an empty #[ORM\Table] has no effect on the mapping, so the rule only produces noise in the diff and can leave the reader wondering where the table mapping went. Keeping the explicit attribute is a valid style choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing an empty
#[ORM\Table]has no effect on the mapping — Doctrine derives the table name from the entity class either way. So the rule only produces diff noise, and the reader of the result is left wondering where the table mapping went.use Doctrine\ORM\Mapping as ORM; -#[ORM\Table] #[ORM\Entity] class Product { }Keeping the explicit attribute is a valid style choice, so this is not something a shared code-quality set should force.
The rule is removed from the
doctrine-code-qualityset and now throws on use, like the other deprecated rules.