Skip to content

Fix e2e scoped build on rector/rector #8314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samsonasik wants to merge 3 commits into from
Closed

Fix e2e scoped build on rector/rector #8314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
262c68d
Fix e2e scoped build on rector/rector
samsonasik Aug 7, 2026
e65d577
[ci-review] Rector Rectify
actions-user Aug 7, 2026
284583b
fix unit test here
samsonasik Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ public function loadIfExistsAndNotLoadedYet(string $filePath): void
do {
$errors[] = $throwable->getMessage();
} while ($throwable = $throwable->getPrevious());

echo Json::encode([
'fatal_errors' => $errors,
]);
Expand Down
2 changes: 1 addition & 1 deletion build/target-repository/e2e/attributes/rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use Rector\ValueObject\PhpVersion;

return static function (RectorConfig $rectorConfig): void {
$rectorConfig->sets([SymfonySetList::SYMFONY_52]);
$rectorConfig->sets([SymfonySetList::ANNOTATIONS_TO_ATTRIBUTES]);

$rectorConfig->phpVersion(PhpVersion::PHP_80);
$rectorConfig->paths([__DIR__ . '/src']);
Expand Down
2 changes: 1 addition & 1 deletion tests/Config/RectorConfigTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public function test(): void
$rectorConfig = $this->getContainer();

$rectorConfig->configure()
->withSets([TwigSetList::TWIG_134])
->withSets([TwigSetList::COMPOSER_BASED])
->withRules([ReturnTypeFromReturnNewRector::class])($rectorConfig);

// only collect root withRules()
Expand Down
Loading