Skip to content

[dx] Include skipped class name in non-Rector-rule warning message - #8325

Merged
TomasVotruba merged 1 commit into
mainfrom
include-broken-class-in-skip-warning
Aug 9, 2026
Merged

[dx] Include skipped class name in non-Rector-rule warning message#8325
TomasVotruba merged 1 commit into
mainfrom
include-broken-class-in-skip-warning

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

The warning for ->withSkip() classes that are not Rector rules printed the class names in a separate listing block below the message. The message itself had no reference to the broken value.

Now the class name is part of the message:

-This skipped class is not a Rector rule, so it can never be skipped. Only classes that
-implement "Rector\Contract\Rector\RectorInterface" can be used in "->withSkip()"
-
- * App\Service\SomeService
+This skipped class "App\Service\SomeService" is not a Rector rule, so it can never be
+skipped. Only classes that implement "Rector\Contract\Rector\RectorInterface" can be
+used in "->withSkip()"

The now redundant listing() call is removed.

@TomasVotruba TomasVotruba changed the title Include skipped class name in non-Rector-rule warning message [dx] Include skipped class name in non-Rector-rule warning message Aug 9, 2026
@TomasVotruba
TomasVotruba enabled auto-merge (squash) August 9, 2026 10:30
@TomasVotruba
TomasVotruba merged commit c6fc794 into main Aug 9, 2026
64 checks passed
@TomasVotruba
TomasVotruba deleted the include-broken-class-in-skip-warning branch August 9, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant