Remove DeprecatedAnnotationToDeprecatedAttributeRector from PHP 8.4 set - #8326
Merged
TomasVotruba merged 2 commits intoAug 9, 2026
Merged
Conversation
The rule turns a `@deprecated` annotation into a `#[\Deprecated]` attribute, which escalates a documentation hint into a runtime deprecation warning. That is rarely the intent when upgrading to PHP 8.4, so the rule should be opt-in instead of part of the set.
TomasVotruba
enabled auto-merge (squash)
August 9, 2026 11:50
TomasVotruba
deleted the
remove-deprecated-annotation-to-attribute-from-php84
branch
August 9, 2026 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeprecatedAnnotationToDeprecatedAttributeRectorchanges a doc annotation into a runtime attribute:final class SomeClass { /** * @deprecated 1.0 Use SomeOtherClass instead */ + #[\Deprecated(message: 'Use SomeOtherClass instead', since: '1.0')] public function oldMethod() { } }#[\Deprecated]makes PHP emit anE_USER_DEPRECATEDon every call. So a comment that only informed the reader now produces runtime noise, and in projects that convert deprecations to exceptions it breaks the test suite.That is not what a PHP 8.4 upgrade is usually about, so the rule is removed from the
php84set. It stays available to register manually, and it stays in thephp-polyfillsset where the opt-in is explicit.