Skip to content

[Caching] Drop MemoryCacheStorage, always use FileCacheStorage #8354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Aug 17, 2026
Merged

[Caching] Drop MemoryCacheStorage, always use FileCacheStorage #8354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/Caching/CacheFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@

namespace Rector\Caching;

use OndraM\CiDetector\CiDetector;
use Rector\Caching\ValueObject\Storage\FileCacheStorage;
use Rector\Caching\ValueObject\Storage\MemoryCacheStorage;
use Rector\Configuration\Option;
use Rector\Configuration\Parameter\SimpleParameterProvider;
use Symfony\Component\Filesystem\Filesystem;
Expand All @@ -23,12 +21,6 @@ public function __construct(
*/
public function create(): Cache
{
// in CI the workspace is ephemeral and usually starts from scratch,
// so a file cache that is never read again is only wasted IO → use faster in-memory cache
if (new CiDetector()->isCiDetected()) {
return new Cache(new MemoryCacheStorage());
}

$cacheDirectory = SimpleParameterProvider::provideStringParameter(Option::CACHE_DIR);

// ensure cache directory exists
Expand Down
52 changes: 0 additions & 52 deletions src/Caching/ValueObject/Storage/MemoryCacheStorage.php
View file
Open in desktop

This file was deleted.

Loading