[SYMFONY73] add failing set test - #1018
Merged
Merged
Conversation
…unctions() Move set-level test to the GetFiltersAndFunctionsToAsTwigAttributeRector rule test, covering an extension mixing an untyped getFilters() with a typed getFunctions().
TomasVotruba
force-pushed
the
SYMFONY73
branch
from
August 11, 2026 09:30
3a3574d to
f31904c
Compare
Member
|
You're right 👍 there was a bug if extension container both, it was skipped. Fixed in #1027 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I expect the test to be successful:
Rector\Symfony\Symfony73\Rector\Class_\GetFiltersToAsTwigFilterAttributeRectorandRector\Symfony\Symfony73\Rector\Class_\GetFunctionsToAsTwigFunctionAttributeRectorshould replace a extension that contains filters and functions right?