[set] remove unused version-based-set constants and configs - #1019
Merged
Conversation
The version sets no longer carry their own configuration, the rules and their composer-bound configuration in "composer-based.php" are the source of truth and are covered by their own tests.
…ES constant The set constants are gone, so the "annotations-to-attributes" set imports the validator attributes set by path, and the ignored deprecation pattern no longer matches anything.
The "setDefaultOptions" rename is bound to symfony/form 2.7 and the "OptionsResolverInterface" rename to symfony/options-resolver 2.7, so the symfony27 set has nothing left to register.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
->withComposerBased(symfony: true)instead: https://getrector.com/documentation/composer-based-setsRef rectorphp/rector-src#7877
Before
Every Symfony version set had to be listed by hand, and each one had to be kept in sync with the very same configuration in
composer-based.php:After
The installed Symfony package versions pick the rules:
What changed
config/sets/symfony/composer-based.php, bound to the exact package version it was introduced inSymfonySetList::SYMFONY_*constants removedtests/Set/Symfony*suites removed - the rules and the composer-based set are the source of truth and have their own tests