[Symfony 7.3] Restore merged AsTwig attribute rules as deprecated - #1028
Merged
Conversation
…es as deprecated Point users to GetFiltersAndFunctionsToAsTwigAttributeRector instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1027 merged
GetFiltersToAsTwigFilterAttributeRectorandGetFunctionsToAsTwigFunctionAttributeRectorinto a singleGetFiltersAndFunctionsToAsTwigAttributeRector, but removed the old classes outright. Anyone referencing them in their ownrector.phpgets a hard "class not found" crash with no hint where the rule went.This restores both classes as deprecated stubs that point to the replacement.
What the deprecated rule does
Running either of the old rules now fails fast with a pointer:
Why they were merged
Converting one
get*()method in isolation leaves a half-converted extension behind:The merged rule converts filters, functions and tests in one pass instead.
Notes
DeprecatedInterface+ShouldNotHappenExceptioninrefactor().composer-based.phpkeeps the merged rule only.