clearer instruction to disable default argocd instance#412
clearer instruction to disable default argocd instance#412makeittotop wants to merge 2 commits intoredhat-developer:masterfrom
Conversation
Clearly mentioning the `env` resource within the `subscriptions.operators.coreos.com.spec.config` CRD to add the associated env. var. leading to disabling the default argocd instance launch
openshift-ci
Bot
added
the
kind/documentation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @makeittotop. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
ok-to-test |
|
/retest |
|
@makeittotop I know it is an old PR but can you rebase this ? |
|
Sure, doing it
…On Wed, Sep 4, 2024 at 10:49 AM Saumeya Katyal ***@***.***> wrote:
@makeittotop <https://github.com/makeittotop> I know it is an old PR but
can you rebase this ?
—
Reply to this email directly, view it on GitHub
<#412 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFYC7JEN7R53GHOBSCPNWDZU5BY5AVCNFSM6AAAAABNU2NLOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZGY2TEMJSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@makeittotop: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
What type of PR is this?
/kind documentation
What does this PR do / why we need it:
Specifically mentioning to edit the
envresource within thesubscriptions.operators.coreos.com.spec.configCRD to add the associated env. var. in order to disable the default argocd instance launch.Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: