Skip to content

fixing auto_viz error #116

Merged
vishnuchalla merged 1 commit into
redhat-performance:mainfrom
Balatripura587:usage_metrics
Jun 11, 2026
Merged

fixing auto_viz error #116
vishnuchalla merged 1 commit into
redhat-performance:mainfrom
Balatripura587:usage_metrics

Conversation

@Balatripura587

Copy link
Copy Markdown
Collaborator

Description

When auto_viz found no viz artifacts , the function returned early, emitting a telemetry event with success=False and no error_type/error_message. The dashboard saw these as failures with no root cause.

Fix

The fix sets success=True before those early returns since "no viz found" is normal behavior, not a failure.

Signed-off-by: Bala Tripura Kumari Bodapati <bbodapat@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 3d24a045-cfd5-418d-abcd-7ba5522e3b86

📥 Commits

Reviewing files that changed from the base of the PR and between 1a090c8 and babed1c.

📒 Files selected for processing (1)
  • bugzooka/integrations/slack_fetcher.py

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Fixed telemetry tracking for visualization operations. When visualizations are unavailable, these operations are now correctly recorded as successful completions, improving the accuracy of operational metrics and analytics reporting.

Walkthrough

SlackMessageFetcher._handle_success_viz modifies two early-return paths to set success = True before returning when visualization URLs are unavailable, changing telemetry reporting from failure to success for these "no visualization" scenarios.

Changes

Telemetry Success Reporting

Layer / File(s) Summary
Success flag for visualization unavailability cases
bugzooka/integrations/slack_fetcher.py
When the method cannot extract view_url or construct_all_orion_viz_urls returns no URLs, the method now sets success = True before returning, altering the telemetry outcome reported in the finally block from failure to success.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the main change: fixing an auto_viz error by correcting telemetry reporting when no visualizations are found.
Description check ✅ Passed The description clearly explains the problem (incorrect telemetry reporting as failure) and the fix (setting success=True for normal no-viz cases).
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vishnuchalla vishnuchalla left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishnuchalla vishnuchalla merged commit 180deb9 into redhat-performance:main Jun 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants