Revert electron-builder to ^26.0.12 — snaps built with 26.12+ fail to launch#6048
Revert electron-builder to ^26.0.12 — snaps built with 26.12+ fail to launch#6048dantovska wants to merge 1 commit into
Conversation
…packaging Reverts the bump to 26.15.2 (#6026). electron-builder >=26.12 replaced the Go app-builder with a TS reimplementation whose archive extractor never untars the inner tar of the snap template (.tar.7z): the built snap ships a stray snap-template-electron-4.0-2-amd64.tar at its root instead of the desktop-integration scripts, and command.sh fails at line 2 with "desktop-init.sh: No such file or directory". Every snap built since the bump is unlaunchable, including the 3.6.0 pre-release. deb/rpm/AppImage are unaffected. Still broken upstream as of 26.15.3. The bump's Wayland motivation does not apply to our config: forceX11 only exists in the new core24/snapcraft path, while the legacy snap config gets DISABLE_WAYLAND=1, which 26.0.12 already sets by default. Verified the 26.0.12-built released snap launches fine on GNOME Wayland Ubuntu 24.04. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7832d49b5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "dotenv": "^16.4.5", | ||
| "electron": "^40.10.2", | ||
| "electron-builder": "^26.15.2", | ||
| "electron-builder": "^26.0.12", |
There was a problem hiding this comment.
Pin electron-builder below the broken 26.12 line
Because this remains a caret range, any future lockfile refresh or dependency upgrade can legally resolve electron-builder back to 26.12+ (including the just-reverted 26.15.2), reintroducing the snap launch failure this commit is trying to avoid. The current yarn.lock masks it for frozen installs, but the package constraint should be exact 26.0.12 or otherwise capped below 26.12.0 so the known-bad versions cannot be selected again.
Useful? React with 👍 / 👎.
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
|
Closing per team direction: instead of reverting, we're fixing forward on electron-builder 26.15.2 with a patch-package patch for the .tar.7z template extraction, targeting release/3.6.0. Replacement PR incoming. |
Code Coverage - Backend unit tests
Test suite run success3454 tests passing in 309 suites. Report generated by 🧪jest coverage report action from a7832d4 |
Code Coverage - Frontend unit tests
Test suite run success7150 tests passing in 814 suites. Report generated by 🧪jest coverage report action from a7832d4 |
What
Reverts the electron-builder bump 26.0.12 → 26.15.2 (#6026). Every snap built since the bump fails to launch — including the 3.6.0 pre-release:
Root cause: electron-builder ≥26.12 replaced the Go app-builder with a TypeScript reimplementation (electron-userland/electron-builder#9829) whose archive extractor handles
.tar.xzin two stages (7z decompress + untar) but routes.tar.7z— the snap template format — into the plain.7zbranch, which never untars the inner tar. The built snap ships a straysnap-template-electron-4.0-2-amd64.tarat its root instead of the desktop-integration launch scripts referenced bycommand.sh. Verified empirically; still broken in 26.15.3. deb/rpm/AppImage targets are unaffected.The bump's Wayland motivation (upstream electron-userland/electron-builder#9452) doesn't apply to our config:
forceX11only exists in the new core24/snapcraft-CLI path, while our legacysnapconfig getsDISABLE_WAYLAND=1— which 26.0.12 already sets by default. Confirmed on GNOME Wayland Ubuntu 24.04 that the released 26.0.12-built snap launches fine.Re-bump only after upstream fixes
.tar.7zextraction; the proper future Wayland improvement is migrating tosnapcraft.core24+forceX11(requires snapcraft CLI on runners).Testing
yarn installgreen in a clean worktree; lockfile stable (frozen-lockfile gate will pass)sudo snap install --dangerous <snap>must launch, andls /snap/redisinsight/current/must listdesktop-init.sh,desktop-common.sh,desktop-gnome-specific.shwith nosnap-template*.tar🤖 Generated with Claude Code
Note
Medium Risk
Packaging regression risk is limited to restoring a known-good snap toolchain; the main concern is staying on an older electron-builder until upstream fixes
.tar.7zextraction.Overview
Downgrades
electron-builderfrom ^26.15.2 to ^26.0.12 and refreshesyarn.lockso Linux snap builds use the older packaging stack again.The snap block in
electron-builder.jsondropsallowNativeWayland: false, leaving onlystagePackages: ["default"]alongside existing plugs/confinement.This is a targeted rollback: newer electron-builder mishandles snap template archives (
.tar.7z), so snaps ship without desktop launch scripts and fail at startup; deb/rpm/AppImage are unchanged.Reviewed by Cursor Bugbot for commit a7832d4. Bugbot is set up for automated code reviews on this repo. Configure here.