Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: configurable vector datatype (int8 quantization) for long-term memory #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat: configurable vector datatype (int8 quantization) for long-term memory #302
Changes from all commits
95316e9d0955b8File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uint8 config lacks quantization
Medium Severity
redisvl_datatypecan be set touint8(validated like other RedisVL types), and_build_redis_schematreatsuint8as quantized, but_maybe_quantizeonly scales forint8. Indexing and search then pass raw float embeddings througharray_to_bufferwithdtype=uint8, so stored/query vectors won’t match a proper uint8 index.Additional Locations (1)
agent_memory_server/memory_vector_db_factory.py#L138-L144Reviewed by Cursor Bugbot for commit d0955b8. Configure here.