Conversation
mich-elle-luna
requested review from
ZdravkoDonev-redis and
andy-stark-redis
September 4, 2026 14:14
andy-stark-redis
approved these changes
Sep 8, 2026
andy-stark-redis
left a comment
Contributor
There was a problem hiding this comment.
Quite a few suggestions but they are easily applied, so I'll approve to avoid delays.
…vs-flink.md Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…e-dbs/_index.md Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…e-dbs/snowflake.md Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…e-dbs/snowflake.md Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…e-dbs/spanner.md Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…e-dbs/spanner.md Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…e-dbs/mongodb.md Co-authored-by: Zdravko Donev <zdravko.donev@redis.com>
zhivko-kirishev-redis
approved these changes
Sep 9, 2026
zhivko-kirishev-redis
left a comment
Collaborator
There was a problem hiding this comment.
Everything about the automatic population of the ssl properties as well as the default Flink processor looks good
nicoweidner
reviewed
Sep 10, 2026
nicoweidner
left a comment
There was a problem hiding this comment.
I left a few comments. We can tackle them in a followup so as not to block the release, none of them are critical
2 tasks
2 tasks
ZdravkoDonev-redis
approved these changes
Sep 13, 2026
nicoweidner
approved these changes
Sep 15, 2026
nicoweidner
left a comment
There was a problem hiding this comment.
Thanks for addressing all comments, looks good to me now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://redislabs.atlassian.net/browse/RDSC-5610
Enhances #3841 with numerous changes and additions. I couldn't update the original PR since I don't have write permissions to this repository.
Note that it now documents 2 PRs that are not yet merged, but should be before the release:
Note
Low Risk
Documentation-only changes; operational risk is misconfiguration if published before the referenced RDI product changes ship.
Overview
Documents multi-source RDI pipelines: one pipeline can ingest from several source databases (each with its own collector, secrets, streams, and metrics), with a new Multiple sources in one pipeline guide covering naming,
config.yaml, jobs (server_name), add/remove sources, per-sourcestop/start/reset, monitoring, and legacy naming after upgrade.Secrets and deploy are rewritten around per-database keys (
USERNAME,PASSWORD, TLS keys) andredis-di set-secret … --db <source|target>, with env vars like${MYSQL_DB_PASSWORD}; K8s examples move fromsource-dbto<source>-db. LegacySOURCE_DB_*/TARGET_DB_*remain for single-source or pre-upgrade sources.Product defaults and fit: architecture, FAQ, pipeline config, and upgrade pages state
processors.typedefaults to Flink (setclassicexplicitly to opt out), including a 2.0.0 upgrade warning that undeployedtypepipelines move to Flink on next deploy. The “when to use” embed and decision tree drop the single-source-only gate and allow one or more sources.Cross-cutting updates cover API v2 requirement for multi-source, DLQ/stream naming with source segments, Flink job matcher lists/
regex:, observability per-collector URLs, HA/standby VM behavior, and refreshed database prep guides (MongoDB keystore, MySQL TLS, Snowflake/Spanner secrets, etc.).Reviewed by Cursor Bugbot for commit 4c412ec. Bugbot is set up for automated code reviews on this repo. Configure here.