Declare RDI's archived versions in doc_bundles.json - #4062
Open
EliShteinman wants to merge 1 commit into
Open
EliShteinman wants to merge 1 commit into
EliShteinman wants to merge 1 commit into
Conversation
DOC-7070 restored RDI's 1.19.1 archive but left the redis-data-integration docset without a "versions" key. The download picker then offers no version choice for RDI, and iter_pages, which skips version directories only for docsets that declare one, packages 1.19.1 into the latest bundle. test_version_directories_require_a_versions_key fails on main for exactly this. "rdi" names the rdi-versions file main.yml already writes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused manifest change addresses the documented versioning issue with no unresolved review comments.
Review effort: Lite
Findings: None
What changed in this PR
Adds version metadata for Redis Data Integration so archived documentation is handled correctly.
Changes:
- Adds
"versions": "rdi"to the RDI docset manifest. - Connects archived versions to the existing version-list workflow.
| File | Description |
|---|---|
data/doc_bundles.json |
Declares RDI’s archived-version source. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build/test_make_doc_bundles.py::test_version_directories_require_a_versions_keyfails onmain:DOC-7070 (
f7ad0b223) restored RDI's version dropdown and archived the current docs ascontent/integrate/redis-data-integration/1.19.1/. It didn't touchdata/doc_bundles.json, so theredis-data-integrationdocset still has noversionskey. The test's own docstring describes the result:iter_pagesskips version directories only for docsets that declareversions, so the latest RDI bundle would include every 1.19.1 page.Change
Add
"versions": "rdi"to theredis-data-integrationentry. The value names therdi-versionsfile thatmain.ymlalready writes for the sidebar dropdown. It follows the same convention asrs,kubernetes, andredisvl.Verification
main,test_version_directories_require_a_versions_keyfails. With this change it passes.build/test_make_doc_bundles.pyis unchanged: 32 passed.test_every_product_is_offeredalso fails onmain.content/operate/radar(Radar docs #3803) is published, but no docset offers it. That needs a decision about how Radar should be offered, so this PR leaves it out.No workflow runs the tests under
build/, which is why neither failure surfaced in CI.🤖 Generated with Claude Code
Note
Low Risk
Single manifest metadata change for downloads/version packaging; no runtime or auth impact.
Overview
Adds
"versions": "rdi"to the Redis Data Integration docset indata/doc_bundles.json, matching other versioned products (rs,kubernetes,redisvl).This wires RDI’s archived
1.19.1content to the existingrdi-versionslist from CI so the download picker can show a version dropdown anditer_pagesdoes not fold every archived tree into the latest bundle.Fixes
test_version_directories_require_a_versions_keyonmain; no other build logic changes.Reviewed by Cursor Bugbot for commit 5bd2866. Bugbot is set up for automated code reviews on this repo. Configure here.