Skip to content

DOC-7104: Fix diff_rendered_hrefs.py to catch unquoted href attributes #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andy-stark-redis merged 1 commit into from
Sep 23, 2026
Merged

DOC-7104: Fix diff_rendered_hrefs.py to catch unquoted href attributes #4087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion build/diff_rendered_hrefs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@
import hashlib

NOISY_PREFIXES = ("develop/ai/redisvl/", "operate/rc/changelog/")
HREF_RX = re.compile(r'href="[^"]*"')
# `hugo --minify` drops attribute quotes wherever the value has no whitespace
# or quote characters, which is nearly always for an href -- on a sampled page
# only 5 of 240 hrefs stayed quoted. A quoted-only pattern therefore
# fingerprints almost nothing and reports "0 diffs" even when links changed.
HREF_RX = re.compile(r'href="[^"]*"|href=\'[^\']*\'|href=[^\s"\'`=<>]+')


def fingerprint(public_dir, prefix_filter=None):
Expand Down
Loading