You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Low Risk
Documentation and diagram assets only; no application or infrastructure code changes.
Overview Corrects Redis Cloud RDI PrivateLink setup docs so they match the recommended path: TCP to the database writer through a dedicated NLB security group, with optional Lambda keeping the IP target group current after RDS failover.
In setup.md, the guide now tells readers to create the target Redis Cloud Pro database first, swaps the RDS/Aurora architecture image for a new SVG that separates database traffic (solid) from SNS → Lambda target-group updates (dashed), and rewrites EC2 and RDS/Aurora NLB steps—Custom TCP and port 5432 for PostgreSQL, NLB-specific target group docs, TCP health checks, writer DNS instead of a “static IP,” and inbound rules sourced from the NLB security group rather than open HTTP. The RDS/Aurora tab frames Lambda as address maintenance, not a proxy for query traffic, and tightens the RDS Proxy callout.
On rds-proxy.md, the former shared Aurora diagram moves here with an explicit non-PostgreSQL note for the proxy alternative.
Reviewed by Cursor Bugbot for commit f9d3c3e. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the database PrivateLink setup instructions and show the recommended connection path.
Changes
Read The Diagram
The diagram follows the existing Redis Lambda module. The text uses short instructions and separates database connections from address updates.
Validation
git diff --checkpassed.Ticket: RDSC-6239. SQL grants: #4293.
Note
Low Risk
Documentation and diagram assets only; no application or infrastructure code changes.
Overview
Corrects Redis Cloud RDI PrivateLink setup docs so they match the recommended path: TCP to the database writer through a dedicated NLB security group, with optional Lambda keeping the IP target group current after RDS failover.
In
setup.md, the guide now tells readers to create the target Redis Cloud Pro database first, swaps the RDS/Aurora architecture image for a new SVG that separates database traffic (solid) from SNS → Lambda target-group updates (dashed), and rewrites EC2 and RDS/Aurora NLB steps—Custom TCP and port5432for PostgreSQL, NLB-specific target group docs, TCP health checks, writer DNS instead of a “static IP,” and inbound rules sourced from the NLB security group rather than open HTTP. The RDS/Aurora tab frames Lambda as address maintenance, not a proxy for query traffic, and tightens the RDS Proxy callout.On
rds-proxy.md, the former shared Aurora diagram moves here with an explicit non-PostgreSQL note for the proxy alternative.Reviewed by Cursor Bugbot for commit f9d3c3e. Bugbot is set up for automated code reviews on this repo. Configure here.