Conversation
The RegisterBatchOutput call was dropped in the MustRegister refactor (7a29588) without a replacement, so no binary has shipped the timeplus output since 4.55.1 even though info.csv lists it for cloud.
The cloud and cloud-ai import tests matched info.csv rows against registered plugins by name only, so the registered timeplus input hid the missing timeplus output. Add InfoCollection.Unregistered, which matches on name and type, and use it in both tests. Also add the reverse of TestAllPluginsInInfoCSV to alltest: every info.csv row must be registered in the all distribution, with an allowlist for the cloud-only and x_benthos_extra plugins.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
timeplusoutput hasn't been registered in any binary since 4.55.1. TheMustRegisterrefactor (7a29588) dropped itsRegisterBatchOutputcall without a replacement, whileinfo.csvstill lists it for cloud. This puts the registration back.Nothing caught it because the cloud and cloud-ai import tests matched
info.csvagainst registered plugins by name only, so the registeredtimeplusinput hid the missing output. They now match on name and type via a newInfoCollection.Unregistered.alltestalso gets the reverse of the existing check: everyinfo.csvrow has to be registered in thealldistribution. The only exceptions are an allowlist fora2a_message(cloud-only) andffi/zmq4(behindx_benthos_extra). Without the timeplus fix, all three tests fail on exactlytimeplus-output.The docs commit is the regenerated output page, which had been stale since the output dropped out of the generator.
🤖 Generated with Claude Code