fix(deps): snyk sweep console frontend#2444
Conversation
|
@claude review |
|
Claude finished @malinskibeniamin's task in 3m 0s —— View job Claude Code Review
SummaryThe intent is sound: bump direct/parent packages, salt CI cache keys, and use Findings1.
If that's accurate, both
If something does import 2.
So the 3.
4. PR title vs. actual diff: no TanStack changes The title says "snyk sweep console frontend" (good) but the body opens with "TanStack supply-chain incident." There are zero 5. Cache-key date salt — works, but a few notes
6. Acceptance criteria — partial From the PR body checklist:
Nits
• Branch: |
|
@claude review |
|
Claude finished @malinskibeniamin's task in 3m 4s —— View job Claude PR Review
SummaryOverall, this is a tightly-scoped security-hygiene PR and the approach is sound: targeted version bumps over blanket overrides, a documented Snyk ignore for non-reachable transitive paths, and a defensive cache-key rotation. The PR description matches the diff. Below are the points worth addressing or at least acknowledging before merge. Findings1. A repo-wide grep for Options:
2. The bun.lock diff cleanly removes the old
Worth running 3.
4. Workflow cache-key date salt is hardcoded.
5. The Rspack cache-key input expansion is a real correctness fix, not just hygiene.
6.
7. Acceptance criteria status. Of the four acceptance-criteria boxes, only the inline "Testing Steps" are checked; the criteria themselves are all unchecked, including "No exact known compromised TanStack versions are present" and "Snyk no longer reports active Axios or UUID findings." The body asserts these were verified via Nits
VerdictLGTM on the security intent and the mechanical correctness of the bumps + cache rotation. Please address (1) the unused direct --- • branch: |
|
@claude review\n\nFollow-up pushed: removed unused direct |
|
Claude finished @malinskibeniamin's task in 2m 4s —— View job Claude PR Review (follow-up)
SummaryThe follow-up commit ( Verification1. Direct deps removed — confirmed
And 2. The previously-flagged
All three match the 3.
4. Workflow cache-key changes unchanged from prior review
Remaining items (non-blocking)
VerdictLGTM on the security intent and the mechanical correctness. The two blocking items from my prior review (unused direct --- · branch: |
|
@claude review Follow-up pushed for the requested MCP transitive Snyk findings:
|
|
Claude finished @malinskibeniamin's task in 2m 23s —— View job Claude PR Review (MCP transitives follow-up)
SummaryThe Verification1.
No stale 2.
Only one 3. Reachability — The PR description groups 4.
5. No new ignores were added for 6. Symmetry between Both Remaining items (non-blocking, carried from prior reviews)
VerdictLGTM on the MCP follow-up. The two --- · branch: |
|
Claude follow-up addressed:
|
|
@claude review Final follow-up pushed after addressing PR/Snyk feedback:
|
|
Claude finished @malinskibeniamin's task in 2m 1s —— View job Claude PR Review (final follow-up)
SummaryThe Verification1.
2.
Note: the prior LaunchDarkly/Storybook references were dropped — good, since neither appears in the remaining transitive UUID resolutions. The rationale now actually matches what's in the tree. ✅ 3. Empty
4. No new ignores added; prior fixes intact — confirmed
5. Workflow cache-key salts intact — confirmed
Remaining items (non-blocking)
VerdictLGTM. The four commits on this branch ( --- · Branch: |
|
Hoisted the frontend Bun/Rspack cache salt into workflow env: env:
BUN_CACHE_SALT: 2026-05-13
|
What
Security sweep for Console frontend covering the May 13, 2026 TanStack supply-chain incident plus Axios/UUID follow-up.
uuid/@types/uuiddependencies and the unusedrsbuild-plugin-devtools-jsondev dependency.BUN_CACHE_SALT: 2026-05-13and includes lock/package inputs in the Rspack cache key.bun upgrade,bun install, andbun i --yarn.Why
TanStack maintainers disclosed malicious npm publishes in the
@tanstack/*namespace, and the sweep also reviewed Axios and UUID advisories. Console frontend did not contain exact compromised TanStack or Axios versions. UUID direct usage was unused, so it was removed; remaining UUID exposure is transitive and covered by reachability-based triage. The unused devtools plugin was also removed after review because no source/config path referenced it. The Rspack cache key also needed dependency inputs to avoid serving stale compiled dependency artifacts.How
rsbuild-plugin-devtools-jsonafter Claude review confirmed no config/source usage.resolutions/overridesonly where needed for the requestedhono/fast-uriMCP/shared-transitive findings..snykonly for remaining not-reachable UUID paths.BUN_CACHE_SALT, and expanded the Rspack key inputs.bun upgrade, thenbun install, thenbun i --yarn.Acceptance Criteria
hono+fast-urifindings for the target scan.BUN_CACHE_SALT: 2026-05-13.Testing Steps
bun upgradebun installbun i --yarngit diff --checkbun run type:checksnyk test --jsonspot scanbun audit --jsonspot scansnyk monitor --target-reference=<branch>pushed branch-scoped snapshotuuid/@types/uuid, eliminating lingeringuuid@13.0.0from the dev treersbuild-plugin-devtools-jsonand tightened.snykrationaleBUN_CACHE_SALT: 2026-05-13Follow-up: MCP transitive Snyk findings
Added after the initial sweep to cover newly reported Snyk findings surfaced through
@modelcontextprotocol/sdk@1.29.0and sharedajvtransitive paths:honoSNYK-JS-HONO-16438966CVE-2026-444564.12.18fast-uriSNYK-JS-FASTURI-16642394CVE-2026-63223.1.2fast-uriSNYK-JS-FASTURI-16642399CVE-2026-63213.1.2Applied via targeted
resolutions/overrides, which forces the fixed versions for every consumer, regenerated both lockfiles withbun installandbun i --yarnafter confirming Bun is already latest withbun upgrade.