add numpy requirement#157
Open
bmaranville wants to merge 2 commits intomainfrom
Open
Conversation
... to support back to python 3.6. We don't really need any new or fancy numpy features in orsopy.
aglavic
approved these changes
Apr 7, 2026
Collaborator
aglavic
left a comment
aglavic
left a comment
There was a problem hiding this comment.
Although I think we could make the library numpy free (using a lot of simple stuff and type annotations) I don't see this as a stringent requirement. Would be surprising if someone does something with python and data without using numpy anywhere...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libraries use numpy in multiple places as a top-level import, so it should really be a dependency.
Doing
pip install orsopythen in python doingimport orsopy.fileiocurrently raises an error because of this.