Move tax curve calculation to mrremind - #2428
Open
simonkrogmann wants to merge 1 commit into
Open
Conversation
simonkrogmann
marked this pull request as draft
August 14, 2026 16:42
simonkrogmann
force-pushed
the
move-taxes
branch
4 times, most recently
from
August 21, 2026 12:19
5fa15ad to
2da8f10
Compare
simonkrogmann
marked this pull request as ready for review
August 21, 2026 12:21
simonkrogmann
force-pushed
the
move-taxes
branch
from
August 21, 2026 14:40
2da8f10 to
2ce3446
Compare
LaviniaBaumstark
left a comment
Member
There was a problem hiding this comment.
this required new input data, rigth?
| *** (note: don't put values to 0 as this will make the model ignore the switch) | ||
| $setGlobal cm_FEtax_trajectory_rel off !! def = off | ||
| *** cm_fetaxscen "choice of final energy tax path and subsidy path, values other than zero enable final energy tax" | ||
| *** even if set to 0, the PE inconvenience cost per SO2-cost for coal are always on if module 21_tax is on |
Member
There was a problem hiding this comment.
why should this not be part of teh switches documentation?
Contributor
Author
There was a problem hiding this comment.
I moved the switch from using parameter to $setGlobal because parameters don't work as compile-time switches necessary for the datainput. Is there a better way for documenting setGlobal?
Member
There was a problem hiding this comment.
starting with *' instead of *** would add this part to the automated model documentation
LaviniaBaumstark
approved these changes
Aug 26, 2026
simonkrogmann
force-pushed
the
move-taxes
branch
from
August 26, 2026 10:21
2ce3446 to
d56a236
Compare
simonkrogmann
force-pushed
the
move-taxes
branch
from
August 26, 2026 13:16
d56a236 to
bf428dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
I moved the tax curve calculation from GAMS to mrremind (see pik-piam/mrremind#845). The subsidy calculation will be left for another PR. This changes behavior for cm_fetaxscen = 5 because some of the previous behavior was unintended. (Treating 0s in the rollback data as NA, confirmed with @nicobauer). Otherwise I confirmed that the taxes computed are exactly the same up to rounding differences.
I will run remind with these changes.
I removed an unused alias as well.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)