fix passing folders using remind_dir in output script - #2435
Merged
Conversation
fbenke-pik
changed the title
fbenke-pik
commented
Aug 24, 2026
| defaultcfg <- readDefaultConfig(".") | ||
| dir_folder <- unique(c("output", dirname(defaultcfg$results_folder))) | ||
| } else { | ||
| dir_folder <- c(file.path(remind_dir, "output"), remind_dir) |
Contributor
Author
There was a problem hiding this comment.
@simonkrogmann Turns out separating comma-separated console input for the argument remind_dir got lost in your refactoring. Is this the right way to fix this?
Contributor
There was a problem hiding this comment.
Looks good. I guess, we need to improve the coverage of make test so it gets caught before the AMTs.
fbenke-pik
marked this pull request as ready for review
August 24, 2026 09:04
LaviniaBaumstark
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix bugs in output script causing reporting failures.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)