Skip to content

feat(i18n): extract settings & account pages (batch 3)#1154

Open
JamieRuderman wants to merge 1 commit into
i18n/extract-noticesfrom
i18n/extract-settings
Open

feat(i18n): extract settings & account pages (batch 3)#1154
JamieRuderman wants to merge 1 commit into
i18n/extract-noticesfrom
i18n/extract-settings

Conversation

@JamieRuderman

Copy link
Copy Markdown
Member

Summary

Batch 3 of Phase 4 extraction: the Settings & Account pages — completing the settings/account area that OptionsPage and ProfilePage started. 34 keys (a new settings.* group + two reusable common.* keys), fully translated to ja/de/es.

Files: SettingsPage, AccountPage, SecurityPage, NotificationsPage + NotificationsMode, and the remaining hardcoded strings in ProfilePage (Profile title, Gravatar caption, Email / Member-since labels, Email Language, Account deletion).

Stacked on i18n/extract-notices (#1153) to inherit the parser and plural-check fixes. The diff here is settings-only. Retarget order once things merge: #1152#1153 → this.

Notes

  • Key reusesettings.profile, settings.security, settings.notifications each label both a nav item and the corresponding page title, so they're defined once and shared. Added common.save / common.saving (used by the webhook form) as reusable keys alongside the existing common.areYouSure.
  • Sentence-case vs title-case — "Sign out everywhere" (heading) and "Sign Out Everywhere" (button) are separate English keys; in ja/de/es they translate identically (the casing distinction doesn't map), which is expected.
  • Embedded links — the Gravatar caption and the webhook help text each end in a link; the sentence and the link label are separate t() calls rather than <Trans>, keeping the link (gravatar.com., Docs) intact. The example webhook URL placeholder is left untranslated (it's a sample URL).
  • No plurals or interpolation in this batch.

Verification

  • i18n:check passes — 4 locales × 3 namespaces, no missing/dead keys, no empty English.
  • tsc clean; production build passes.

Untranslated strings elsewhere still fall back to English.

🤖 Generated with Claude Code

@JamieRuderman

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d2297f6bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +56 to +57
<br /> {t('settings.gravatarEdit', 'To edit or add a profile image please visit')}
<Link href="https://gravatar.com">gravatar.com.</Link>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add spacing before the Gravatar link

When the UI language is German or Spanish, settings.gravatarEdit ends in an ordinary word (bitte or visita), but this link is placed immediately after the translated expression without explicit whitespace. JSX does not preserve the formatting newline here, so the caption renders as bittegravatar.com. or visitagravatar.com.; add {' '} before the link, as the webhook caption does.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant