fix(validation): multipleOf rejected valid fractional multiples - #272
Merged
Merged
Conversation
multipleOf used a native remainder, which is unreliable for fractional divisors: 0.0001 has no exact binary representation, so `3.025 % 0.0001` yields 0.00009999999999976622 instead of 0 and the value is rejected. Both operands are now scaled to whole numbers via their exact decimal parts and compared with a bigint remainder. Integer operands keep the native remainder, which is already exact for them. Fixes #222
sandrina-p
requested review from
antoniocapelo and
sandrina-p
and removed request for
antoniocapelo
September 8, 2026 09:01
sandrina-p
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multipleOfused a native remainder, which is unreliable for fractional divisors: 0.0001 has no exact binary representation, so3.025 % 0.0001yields 0.00009999999999976622 instead of 0 and the value is rejected.Both operands are now scaled to whole numbers via their exact decimal parts and compared with a bigint remainder.
Integer operands keep the native remainder, which is already exact for them.
Fixes #222