fix(v0): export type aliases used in json-schema-form.d.ts public API - #275
Merged
Merged
Conversation
Fields, $TSFixMe, HeadlessFormOutput, FieldAttrs, JSONSchemaObjectType,
and 7 other type aliases are used throughout v0's public function
signatures but were never `export`ed themselves. rollup-plugin-dts
(used by tsup consumers) tolerates this silently, but rolldown-plugin-dts
(used by tsdown consumers) does not: it flags `Import 'Fields' will
always be undefined` and drops the type entirely, which cascades into
`possibly undefined` / implicit-any errors for any consumer re-exporting
these names by value (e.g. @remoteoss/remote-json-schema-form-kit's
`export type { Fields, FieldAttrs, JSONSchemaObjectType,
HeadlessFormOutput } from '@remoteoss/json-schema-form-v0-deprecated'`).
Purely additive (adds `export` to existing type aliases), no runtime
or type-shape change for existing consumers.
Verified against a real downstream consumer (remoteoss/remote-flows,
mid-migration from tsup to tsdown for TypeScript 7 support): before
this fix, tsdown's dts build emitted 15 IMPORT_IS_UNDEFINED warnings
and the consuming example app failed `tsc -b` with 6 errors; after
patching this file locally, both are clean (0 warnings, 0 errors).
ollyd
self-requested a review
September 16, 2026 23:17
ollyd
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I was doing some migration replacement and I bumped into a new problem while replacing tsup with
tsdownI created a dev version and the change is working for my library
Could we ship this as this feels like a no brainer
I update tool_versions as I was having problem with the dev:release script
Note
Low Risk
Additive type exports and dev toolchain version pins only; no runtime or validation logic changes.
Overview
Exports 12 type aliases in
json-schema-form.d.ts(Fields,HeadlessFormOutput,JSFConfig,ModifyConfig, and related names) that were already used in public function signatures but were not importable. This fixesrolldown-plugin-dts/tsdownbuilds that treat those names as undefined and break downstream re-exports (e.g.@remoteoss/remote-json-schema-form-kit).Pins local Node to 22.13.1 in
v0/.nvmrcandv0/.tool-versions(from 18.14.0).Reviewed by Cursor Bugbot for commit 7ec77ef. Bugbot is set up for automated code reviews on this repo. Configure here.