Skip to content

Fix reanalyze build after Tarrow representation change - #8548

Merged
cristianoc merged 1 commit into
masterfrom
fix-ci
Aug 14, 2026
Merged

Fix reanalyze build after Tarrow representation change#8548
cristianoc merged 1 commit into
masterfrom
fix-ci

Conversation

@cknitt

@cknitt cknitt commented Aug 14, 2026

Copy link
Copy Markdown
Member

Update dead_optional_args.ml to use the current three-field Tarrow constructor.

The stale four-field patterns caused clean compiler builds to fail while compiling analysis/reanalyze.

@cknitt
cknitt requested a review from cristianoc August 14, 2026 12:52

@cristianoc cristianoc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase on merge broke it

@cristianoc
cristianoc enabled auto-merge (rebase) August 14, 2026 13:01
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.84%. Comparing base (5df516f) to head (c4c161d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8548      +/-   ##
==========================================
- Coverage   74.84%   74.84%   -0.01%     
==========================================
  Files         477      477              
  Lines       63360    63331      -29     
==========================================
- Hits        47421    47398      -23     
+ Misses      15939    15933       -6     
Files with missing lines Coverage Δ
analysis/reanalyze/src/dead_optional_args.ml 86.66% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Aug 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8548

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8548

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8548

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8548

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8548

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8548

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8548

commit: c4c161d

@cristianoc
cristianoc merged commit 65cf698 into master Aug 14, 2026
29 checks passed
@cristianoc
cristianoc deleted the fix-ci branch August 14, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants