Clean up unused compiler IR definitions - #8551
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8551 +/- ##
==========================================
+ Coverage 74.84% 74.88% +0.04%
==========================================
Files 477 476 -1
Lines 63331 63269 -62
==========================================
- Hits 47398 47382 -16
+ Misses 15933 15887 -46
🚀 New features to boost your workflow:
|
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
cknitt
force-pushed
the
codex/cleanup-js-ir
branch
from
August 15, 2026 16:12
508ce9b to
e9d59d1
Compare
cknitt
marked this pull request as ready for review
August 15, 2026 16:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Js_exp_make.Bnotconstructor and obsolete type aliases.LengthandArrayexpressions and the unnecessary optional argument representation fromNewexpressions.Js_arrhelpers intoJs_of_lam_array.Pmakeblockmutability used by optimizer patterns.Why
The exponentiation precedence investigation exposed definitions and metadata left behind by earlier compiler changes. Keeping them makes the compiler IRs appear to support distinctions and operations that are never constructed or observed.
The cleanup deliberately retains meaningful mutability information. Core
Pmakeblockcaches mutability derived at the ML-to-core boundary because many optimizer passes pattern-match on it. JavaScriptCaml_blockalso distinguishes mutable list cells, immutable blocks, and constant blocks that should not be flattened.This cleanup does not change generated JavaScript. It narrows the IR and helper interfaces to the states and operations the compiler actually uses.
Validation
make testmake checkformatgit diff --check