Repository navigation
Keep the caller's spelling of the project root in OCaml compiler-args - #8867
Merged
Merged
Conversation
Rust rewatch does since #8639, and its new GenType test checks it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WZbCuRQ1Tn31bnKzLj5e72 Signed-off-by: Christoph Knittel <ck@cca.io>
cknitt
force-pushed
the
fix-compiler-args-project-root
branch
from
October 15, 2026 16:53
ff72693 to
c28fa47
Compare
cknitt
marked this pull request as ready for review
October 15, 2026 16:53
fhammerschmidt
approved these changes
Oct 15, 2026
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
cknitt
enabled auto-merge (squash)
October 15, 2026 17:05
…t does Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WZbCuRQ1Tn31bnKzLj5e72 Signed-off-by: Christoph Knittel <ck@cca.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WZbCuRQ1Tn31bnKzLj5e72 Signed-off-by: Christoph Knittel <ck@cca.io>
cknitt
disabled auto-merge
October 15, 2026 17:50
cknitt
enabled auto-merge (squash)
October 15, 2026 17:50
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8867 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master's CI fails since the OCaml rewatch stack merged. #8639, merged shortly before the stack, changed Rust rewatch's
compiler-argsto report the project root as the caller spelled the source path, such as through a symlink or a Windows 8.3 short path, instead of the canonical path. Its new shared test,rewatch/tests/gentype/01-gentype-project-root.sh, checks that, and OCaml rewatch still canonicalized it, on every platform.compiler-argsin OCaml rewatch now does what Rust does: it takes the nearestrescript.jsondirectory of the source path made absolute without resolving symlinks, and passes it as-bs-project-root. Everything else still uses the canonical project, and builds keep passing the canonical package root.The shared test covers the change: it fails on master and passes with this PR.
On Windows, the project root is spelled with backslashes throughout, as Rust builds it from its components; the Rust/OCaml configuration comparison checks that.
Separately,
run.shno longer fails when an interrupted build has already stopped before the test sends its second interrupt, which happened on the OCaml 5.0 job.🤖 Generated with Claude Code