Repository navigation
Derive changelog PR links from the squash commit - #8888
Conversation
Fragments no longer need a PR link, so new PRs don't need the placeholder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NP47qMfjMbjUTKZDsLthDo Signed-off-by: Christoph Knittel <ck@cca.io>
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8888 |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcc6488fff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NP47qMfjMbjUTKZDsLthDo Signed-off-by: Christoph Knittel <ck@cca.io>
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Changelog fragments no longer contain PR links. A fragment is just the entry:
- Recover blocked dependents after a failed build.yarn changelog:releaseadds each link itself, from the squash commit that merged the fragment (… (#8667)). New PRs no longer need the draft with thepull/XXXXplaceholder, and the amend once the number is known.scripts/changelog.js:(#N). It writes nothing in that case.mastertraces every linkless fragment to its PR, so a merge without(#N)fails right after it lands rather than at release time.changes/README.mdandAGENTS.md: the placeholder steps are replaced by the squash-merge rule.Repository settings
This relies on PRs being squash-merged with the
(#N)GitHub adds to the title. The repository now allows only squash merges, titled with the PR title and(#N)("Default to pull request title and commit details"). Since v13.0.0-alpha.6, 128 of 131 commits onmasterwere squash merges. The other 3 were rebase merges (#8870, #8669) and carry no PR number.Checked against history
I stripped the links from every fragment on
masterand derived them again. 46 of 47 fragments got exactly their original links back, and the release produces an identicalCHANGELOG.md. The one miss iscommit-records.internal.md, from the rebase-merged #8870; the release refuses it as described above. This PR's own fragment has no link, so it resolves once this PR is squash-merged.Tests
scripts/changelog.test.js:🤖 Generated with Claude Code
https://claude.ai/code/session_01NP47qMfjMbjUTKZDsLthDo