Repository navigation
Keep optimized Lambda output compatible with playground API v8 - #8930
Merged
Merged
Conversation
Why:
lambda_optimized is an optional compileWithDebug field. Existing compiler
calls remain compatible, so advertising API v9 needlessly makes clients
with an explicit version allowlist reject the bundle.
Restore API v8 and keep optimized Lambda output intact. Consumers detect the
field's presence. Remove the v9 requirement from the availability notice,
contributor guide, and original changelog entry.
Review: The bundle test requires API v8 and optimized output together, and
continues to verify that regular compilation does not capture that output.
The older-bundle UI test rejects the obsolete API-v9 guidance.
Validation: Native and browser compiler builds, the compiler suites,
playground bundle tests, all 37 developer playground tests under Node 22
with locked rescript-signals 3.1.1, the production Vite build, and format
checks pass.
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
fhammerschmidt
force-pushed
the
fix/playground-api-v8
branch
from
October 20, 2026 13:32
e1feb10 to
ac42462
Compare
fhammerschmidt
marked this pull request as ready for review
October 20, 2026 13:32
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Remove the added API-v9 text assertion and the optional debug-output comment as requested in review. The API-v8 bundle regression remains in place. Validation: make compiler and all 26 Lambda diff tests pass. Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
cknitt
approved these changes
Oct 20, 2026
fhammerschmidt
enabled auto-merge (squash)
October 20, 2026 13:42
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8930 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the optional
lambda_optimizedfield tocompileWithDebugin #8636 did not change the existing compiler API. Advertising v9 nevertheless makes existing clients with explicit API allowlists reject the bundle.Restore
api_version = "8"while retaining optimized Lambda output and the before/after/diff views. Keep capability detection based on field presence, and remove the v9 requirement from the UI guidance, contributor documentation, and original changelog entry.The bundle test now requires API v8 and optimized output together, while preserving its checks for regular compilation.
Validation:
This makes rescript-lang/rescript-lang.org#1457 unnecessary.