Skip to content

Create the Random instance only once #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slinkydeveloper merged 1 commit into from
May 5, 2026
Merged

Create the Random instance only once #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sdk-api-kotlin/src/main/kotlin/dev/restate/sdk/kotlin/ContextImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ internal constructor(
internal val contextSerdeFactory: SerdeFactory,
) : WorkflowContext {

internal val random: RestateRandom =
RestateRandom(handlerContext.request().invocationId().toRandomSeed())

override fun key(): String {
return this.handlerContext.objectKey()
}
Expand Down Expand Up @@ -191,7 +194,7 @@ internal constructor(
}

override fun random(): RestateRandom {
return RestateRandom(handlerContext.request().invocationId().toRandomSeed())
return this.random
}

override fun <T : Any> promise(key: DurablePromiseKey<T>): DurablePromise<T> {
Expand Down
4 changes: 3 additions & 1 deletion sdk-api/src/main/java/dev/restate/sdk/ContextImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,13 @@ class ContextImpl implements ObjectContext, WorkflowContext {
private final HandlerContext handlerContext;
private final Executor serviceExecutor;
private final SerdeFactory serdeFactory;
private final RestateRandom random;

ContextImpl(HandlerContext handlerContext, Executor serviceExecutor, SerdeFactory serdeFactory) {
this.handlerContext = handlerContext;
this.serviceExecutor = serviceExecutor;
this.serdeFactory = serdeFactory;
this.random = new RestateRandom(this.request().invocationId().toRandomSeed());
}

static void checkNotInsideRun() {
Expand Down Expand Up @@ -275,7 +277,7 @@ public void reject(String reason) {

@Override
public RestateRandom random() {
return new RestateRandom(this.request().invocationId().toRandomSeed());
return this.random;
}

@Override
Expand Down
Loading