fix(test): pass http_client to ApplicationContext::new in queue test - #268
Open
ftong2010 wants to merge 1 commit into
Open
fix(test): pass http_client to ApplicationContext::new in queue test#268ftong2010 wants to merge 1 commit into
ftong2010 wants to merge 1 commit into
Conversation
ApplicationContext::new gained an http_client parameter but one queue test call site was not updated, so `cargo test --lib` fails to compile on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cargo test --libdoes not compile onmain:ApplicationContext::newgained an
http_clientparameter, but one call site insrc/call/app/queue_test.rswas not updated (the other call sites were).Fix
Pass
reqwest::Client::new()as the fourth argument at the stale callsite. One line, test-only.
Verification
cargo test --libnow compiles (same pass/fail set as before thesignature change introduced the breakage).