Skip to content

[DX-660] Rulesets for main and branch names as files - #14

Merged
elmarhepp merged 1 commit into
mainfrom
chore/dx-660-rulesets
Oct 30, 2026
Merged

elmarhepp merged 1 commit into
mainfrom
chore/dx-660-rulesets

Conversation

@elmarhepp

@elmarhepp elmarhepp commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Why

DX-660, CI/CD standard §4.1 (atlas handbook/engineering/cicd-standard.md): main is protected by a ruleset committed to the repository. sample-data has no ruleset today, so nothing stops a direct push or a red merge.

What

  • .github/rulesets/main.json:
    • 1 approving review from a code owner (@revenexx/developer-experience).
    • Required checks: shell (run lock) and tui (install · format · lint · types · test), both jobs of ci.yml.
    • No deletion, no force-push, bypass_actors: [].
  • .github/rulesets/branch-names.json:
    • Creation is restricted to feature, fix, chore, doc, docs (each followed by / or -), plus Dependabot.
    • It is a creation rule with exclusions, like every live revenexx ruleset. A branch-name pattern rule (branch_name_pattern) is stored on GitHub Team and enforces nothing: on 2026-10-30 probe-dx660 was pushed to pick-the-place past one. The creation rule is enforced: skills-catalog's live rule turned away a fix/… push the same day (GH013).
    • Existing branches outside the pattern (ownership/adr-0104, sample-data-media) stay. Only creating new ones is refused.

After merge: an admin applies the rulesets

gh api -X POST repos/revenexx/sample-data/rulesets --input .github/rulesets/main.json
gh api -X POST repos/revenexx/sample-data/rulesets --input .github/rulesets/branch-names.json

🤖 Generated with Claude Code

- main.json: one code-owner review, no force-push or deletion, both CI jobs
  required.
- branch-names.json: only type-prefixed branches may be created, Dependabot
  exempt. A creation rule with exclusions, since branch-name patterns need
  GitHub Enterprise.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@elmarhepp
elmarhepp requested a review from a team as a code owner October 30, 2026 13:33
@elmarhepp
elmarhepp merged commit 1b3fa05 into main Oct 30, 2026
2 checks passed
@elmarhepp
elmarhepp deleted the chore/dx-660-rulesets branch October 30, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant