Repository navigation
chore(deps): bump react and @types/react in /tui - #6
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [react](https://github.com/react/react/tree/HEAD/packages/react) and [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react). These dependencies needed to be updated together. Updates `react` from 18.3.1 to 19.3.1 - [Release notes](https://github.com/react/react/releases) - [Changelog](https://github.com/react/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/react/react/commits/v19.3.1/packages/react) Updates `@types/react` from 18.3.31 to 19.3.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: react dependency-version: 19.3.1 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/react" dependency-version: 19.3.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
elmarhepp
left a comment
There was a problem hiding this comment.
Requesting changes: one blocking issue, see the inline comments.
The bump moves React to 19 and its types to 19 in tui/, but the lockfile shows ink 5 still runs on its bundled react-reconciler 0.29, which is built for React 18 and has a React 18 peer dependency. The TUI would likely fail at runtime or at install, which fits the one failing CI check. The diff does not show whether the TUI source still type-checks and runs under React 19, so this change does not hold up as it stands.
Notes:
tui/package-lock.json: CI reports one failing check, but the PR does not say which one or why. Please check the failing job's log before merging. If it is the install or type-check step, it is probably the peer or type mismatch described above.
Questions:
- Does the TUI still render with React 19 when
ink5 uses its ownreact-reconciler0.29? Was this tested locally? - Which CI check fails, and what does its log say?
- Does the TUI source (
.tsx) need changes for React 19 types, such asuseRef()arguments orchildrentyping? If so, why are they missing? - Should
inkbe upgraded in the same PR, since the bump only works ifinksupports React 19?
Prepared with Meow (Claude), reviewed by Elmar.
| } | ||
| } | ||
| }, | ||
| "node_modules/ink/node_modules/react-reconciler": { |
There was a problem hiding this comment.
ink (^5.2.1) is not bumped, and the lockfile now nests react-reconciler 0.29.2 under node_modules/ink/node_modules/. That reconciler is built for React 18 internals and declares peerDependencies: { react: "^18.3.1" }, while the root react is now 19.3.1. The mismatch can break npm ci on strict peer resolution, and at runtime the reconciler can fail against React 19 internals, so the TUI may not render at all. Please verify that ink renders with React 19 (or upgrade ink to a release built on a React 19 compatible reconciler) before merging.
| "dependencies": { | ||
| "ink": "^5.2.1", | ||
| "react": "^18.3.1", | ||
| "react": "^19.3.1", |
There was a problem hiding this comment.
Note, not blocking: React 19 and @types/react 19 change APIs that TUI code often relies on: useRef() now requires an argument, implicit children on React.FC was removed, and the global JSX namespace is gone. The diff does not touch any .tsx source, so either the code already conforms or the type-check and tests were not run against this change. Please run tsc and the TUI tests on this branch and confirm they pass.
|
Superseded by #10. |
Bumps react and @types/react. These dependencies needed to be updated together.
Updates
reactfrom 18.3.1 to 19.3.1Release notes
Sourced from react's releases.
... (truncated)
Changelog
Sourced from react's changelog.
... (truncated)
Commits
61aa00d[19.3.x][Flight] Improve transport protocol (#37845)2dc7da7[test] Bump Jest to 30.4 (#37382)4f93894docs: remove stale parentType param from validateChildKeys JSDoc (#36928)dbc3750Update required references to GitHub repo (#36752)900ae09[flow] Bump flow to v0.317.0 (#36701)fbb1370[flow] Bump flow to v0.307.1 (#36199)56922cf[react-native-renderer] Delete Paper (legacy) renderer (#36285)74568e8[Flight] TransportAggregateErrors.errors(#36156)e66ef64[tests] remove withoutStack from assertConsole helpers (#35498)db71391[Fiber] Instrument the lazy initializer thenable in all cases (#35521)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for react since your current version.
Updates
@types/reactfrom 18.3.31 to 19.3.0Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)