Skip to content

chore(deps): bump react and @types/react in /tui - #6

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/tui/multi-b1658bdecd
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/tui/multi-b1658bdecd

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 28, 2026

Copy link
Copy Markdown
Contributor

Bumps react and @types/react. These dependencies needed to be updated together.
Updates react from 18.3.1 to 19.3.1

Release notes

Sourced from react's releases.

19.3.1 (October 14th, 2026)

React Server Components

19.3.0 (September 9, 2026)

Below is a list of all new features, APIs, and bug fixes.

Read the React 19.3 release post for more information.

New React Features

New React DOM Features

  • browser(): a new react-dom API that returns a usable which errors during server rendering and resolves in the browser. use(browser()) inside a <Suspense> boundary marks a subtree as browser-only without reporting a recoverable error (@​gnoff: #37143, #37241)
    • Added an onBrowserBailout option to the react-dom/server APIs to observe when a subtree defers to the browser (@​gnoff #37193)

Notable changes

All Changes

React

  • Fast Refresh Fixes
  • Performance Track Fixes
    • Prevent crash when accessing $$typeof in Performance Tracks (@​eps1lon #35679)
    • Handle non-string function names in Performance Tracks (@​eps1lon #35659)
    • Use minus (-) instead of en dash for removed props in Performance Tracks (@​eps1lon #35649)
    • Handle arrays with bigints in deep objects in Performance Tracks (@​eps1lon #35648)
    • Don't enumerate typed array props in Performance Tracks in DEV (@​UditDewan #36913)
    • Bail out of diffing wide objects and arrays in Performance Tracks (@​eps1lon #34742)
    • Clear potentially large performance measures in DEV (@​hoxyq #34803)
    • Fix missing else branch for renders with no props change in Performance Tracks (@​hoxyq #34837)
  • Activity Fixes

... (truncated)

Changelog

Sourced from react's changelog.

19.3.0 (September 9, 2026)

New React Features

New React DOM Features

  • browser(): a new react-dom API that returns a usable which errors during server rendering and resolves in the browser. use(browser()) inside a <Suspense> boundary marks a subtree as browser-only without reporting a recoverable error (@​gnoff: #37143, #37241)
    • Added an onBrowserBailout option to the react-dom/server APIs to observe when a subtree defers to the browser (@​gnoff #37193)

Notable changes

All Changes

React

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by GitHub Actions, a new releaser for react since your current version.


Updates @types/react from 18.3.31 to 19.3.0

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [react](https://github.com/react/react/tree/HEAD/packages/react) and [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react). These dependencies needed to be updated together.

Updates `react` from 18.3.1 to 19.3.1
- [Release notes](https://github.com/react/react/releases)
- [Changelog](https://github.com/react/react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/react/react/commits/v19.3.1/packages/react)

Updates `@types/react` from 18.3.31 to 19.3.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: react
  dependency-version: 19.3.1
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: "@types/react"
  dependency-version: 19.3.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Oct 28, 2026
@dependabot
dependabot Bot requested a review from a team as a code owner October 28, 2026 15:46

@elmarhepp elmarhepp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes: one blocking issue, see the inline comments.

The bump moves React to 19 and its types to 19 in tui/, but the lockfile shows ink 5 still runs on its bundled react-reconciler 0.29, which is built for React 18 and has a React 18 peer dependency. The TUI would likely fail at runtime or at install, which fits the one failing CI check. The diff does not show whether the TUI source still type-checks and runs under React 19, so this change does not hold up as it stands.

Notes:

  1. tui/package-lock.json: CI reports one failing check, but the PR does not say which one or why. Please check the failing job's log before merging. If it is the install or type-check step, it is probably the peer or type mismatch described above.

Questions:

  • Does the TUI still render with React 19 when ink 5 uses its own react-reconciler 0.29? Was this tested locally?
  • Which CI check fails, and what does its log say?
  • Does the TUI source (.tsx) need changes for React 19 types, such as useRef() arguments or children typing? If so, why are they missing?
  • Should ink be upgraded in the same PR, since the bump only works if ink supports React 19?

Prepared with Meow (Claude), reviewed by Elmar.

Comment thread tui/package-lock.json
}
}
},
"node_modules/ink/node_modules/react-reconciler": {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ink (^5.2.1) is not bumped, and the lockfile now nests react-reconciler 0.29.2 under node_modules/ink/node_modules/. That reconciler is built for React 18 internals and declares peerDependencies: { react: "^18.3.1" }, while the root react is now 19.3.1. The mismatch can break npm ci on strict peer resolution, and at runtime the reconciler can fail against React 19 internals, so the TUI may not render at all. Please verify that ink renders with React 19 (or upgrade ink to a release built on a React 19 compatible reconciler) before merging.

Comment thread tui/package.json
"dependencies": {
"ink": "^5.2.1",
"react": "^18.3.1",
"react": "^19.3.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, not blocking: React 19 and @types/react 19 change APIs that TUI code often relies on: useRef() now requires an argument, implicit children on React.FC was removed, and the global JSX namespace is gone. The diff does not touch any .tsx source, so either the code already conforms or the type-check and tests were not run against this change. Please run tsc and the TUI tests on this branch and confirm they pass.

@dependabot @github

dependabot Bot commented on behalf of github Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #10.

@dependabot dependabot Bot closed this Oct 29, 2026
@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/tui/multi-b1658bdecd branch October 29, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant