Repository navigation
chore(deps): bump typescript from 5.9.3 to 7.0.2 in /tui - #7
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.9.3 to 7.0.2. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v5.9.3...v7.0.2) --- updated-dependencies: - dependency-name: typescript dependency-version: 7.0.2 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
the
dependencies
elmarhepp
left a comment
elmarhepp
left a comment
There was a problem hiding this comment.
Requesting changes: one blocking issue, see the inline comments.
The PR bumps TypeScript in tui/ to the major version 7.0.2 without touching typescript-eslint. The lockfile shows that typescript-eslint 8.72.0 and all nested @typescript-eslint/* packages declare the peer range typescript >=4.8.4 <6.1.0, which 7.0.2 violates. As a result, npm ci with npm 7+ fails with a peer conflict. The PR should not be merged as it is: either keep TypeScript below 6.1 or upgrade typescript-eslint to a release that supports TypeScript 7 in the same PR.
Notes:
tui/package-lock.json: Dependabot notes that this release was pushed to npm by a new releaser,microsoft1es, since the current version. The lockfile integrity hashes match the registry, but for a major version with a new distribution model (native per-platform optional packages), it is worth confirming that the publisher is the expected Microsoft TypeScript release channel before merging.
Questions:
- What does the failing CI check show? Is it the
npm cipeer conflict, a lint failure, or a build failure with TypeScript 7? - Do the
tuiscripts or tooling usetsserveror the TypeScript JS API directly, or only thetscbinary? - Does
tui/tsconfig.jsonuse options that were deprecated in TypeScript 6.0 (for examplebaseUrl,moduleResolution: node10, ortarget: es5)? - Was the dependency resolved with
--legacy-peer-depsor a similar flag locally, and doesnpm cipass without it?
Prepared with Meow (Claude), reviewed by Elmar.
| "ink-testing-library": "^4.0.0", | ||
| "prettier": "^3.9.10", | ||
| "typescript": "^5.6.0", | ||
| "typescript": "^7.0.2", |
There was a problem hiding this comment.
typescript is bumped to ^7.0.2, but the installed typescript-eslint 8.72.0 (and its nested @typescript-eslint/* packages in the lockfile) declare the peer range typescript >=4.8.4 <6.1.0. This peer conflict makes npm ci fail under npm 7+ unless --legacy-peer-deps is used, and it is a likely cause of the failing CI check. Keep TypeScript within the range that typescript-eslint supports, or upgrade typescript-eslint to a release that supports TypeScript 7 in the same PR, and confirm that npm ci, lint and build pass.
| @@ -2360,6 +2541,186 @@ | |||
| "typescript": ">=4.8.4 <6.1.0" | |||
There was a problem hiding this comment.
Note, not blocking: The lockfile now nests @typescript-eslint/eslint-plugin, parser, typescript-estree, utils and ignore under node_modules/typescript-eslint/node_modules/..., and the top-level @typescript-eslint/* entries were moved or removed. The diff alone does not show why. Any ESLint configuration or tool that imports these packages from the top level could resolve different versions or fail. Regenerate the lockfile with the tooling pinned in the repo and verify that the ESLint config still loads.
| @@ -2323,17 +2483,38 @@ | |||
| } | |||
There was a problem hiding this comment.
Note, not blocking: TypeScript 7 is a native rewrite. The tsserver bin was removed from the package, and the JavaScript API may differ from 5.x. Any script, editor integration, or tool in tui/ that calls tsserver or require('typescript') will break. The PR does not show a build or test run against TypeScript 7, and tsconfig options that were deprecated in 6.0 may be removed in 7. Run tsc --noEmit and the test suite locally before merging, and check the tsconfig for removed options.
|
Superseded by #10. |
Bumps typescript from 5.9.3 to 7.0.2.
Release notes
Sourced from typescript's releases.
Commits
1e4744dMerge branch 'main' into ts7-releasea5a219cmicrosoft/typescript-go#4558ecfe30dUpdate status localization5de25b5Hide executable name in TypeScript statusd7ce74aShow bundled TypeScript version for packaged servers29be66aCorrect TS 7 release version to 7.0.2ed2bd1bMerge branch 'main' into ts7-release8873075Bump the github-actions group across 1 directory with 3 updates (microsoft/ty...9427131Set up stable / nightly extension split, other prep (microsoft/typescript-go#...d4eaca5microsoft/typescript-go#4549Maintainer changes
This version was pushed to npm by microsoft1es, a new releaser for typescript since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)