Skip to content

[CRM-14077] Lift PHP cap to <8.4 and add 8.3 to CI #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelEsteves merged 3 commits into from
Jul 3, 2026
Merged

[CRM-14077] Lift PHP cap to <8.4 and add 8.3 to CI #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fa7cec
chore: CRM-14077 lift PHP cap to <8.5
MichaelEsteves Jul 3, 2026
b8dc934
chore: CRM-14077 add PHP 8.3 to the CI matrix
MichaelEsteves Jul 3, 2026
5df4453
fix: CRM-14077 narrow the lift to <8.4 — claim only the CI-validated …
MichaelEsteves Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: ["7.4", "8.0", "8.1", "8.2"]
php: ["7.4", "8.0", "8.1", "8.2", "8.3"]

@greptile-apps greptile-apps Bot Jul 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The composer constraint now allows PHP 8.4 (<8.5), but 8.4 is not included in the test matrix. PHP 8.4 has been released since November 2024 and ships several deprecation-to-error promotions and other behavioural changes that could silently break consumers. Without a 8.4 CI run, the package is effectively advertising support it hasn't verified.

Suggested change
php: ["7.4", "8.0", "8.1", "8.2", "8.3"]
php: ["7.4", "8.0", "8.1", "8.2", "8.3", "8.4"]
Prompt To Fix With AI 
This is a comment left during a code review.
Path: .github/workflows/pr_test.yml
Line: 14

Comment:
The composer constraint now allows PHP 8.4 (`<8.5`), but 8.4 is not included in the test matrix. PHP 8.4 has been released since November 2024 and ships several deprecation-to-error promotions and other behavioural changes that could silently break consumers. Without a 8.4 CI run, the package is effectively advertising support it hasn't verified.

```suggestion
        php: ["7.4", "8.0", "8.1", "8.2", "8.3", "8.4"]
```

How can I resolve this? If you propose a fix, please make it concise.

composer-version: [prefer-lowest, prefer-stable]
steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"minimum-stability": "stable",
"require": {
"php" : ">=7.4 <8.3",
"php" : ">=7.4 <8.4",
"rexlabs/utility-belt": "^4.0"
},
"require-dev": {
Expand Down
Loading