feat(skills): sparse fetch, ls-remote branch detection, prompt polish#23
Merged
Merged
Conversation
Fix three issues in `skills add`: - Default branch detection: replace GitHub REST API (rate-limited at 403 unauthenticated) with `git ls-remote --symref <url> HEAD`, which needs no auth and no quota. REST API kept as fallback. Resolves the silent fallback to `main` that caused `vercel/next.js` (default branch `canary`) to report "no skills found". - Download size: replace giget full-tarball download with a partial sparse git clone (`--no-checkout --depth 1 --filter=blob:none` + `sparse-checkout set` in cone mode) scoped to only the needed subtree (`skills/` for discovery, `source.subPath` for install). Drops the `giget` dependency. - Discovery scope: `findSkillsInRepo` now walks only from the repo's root `skills/` directory instead of the entire tree, making the scan fast and predictable. - Error message: "no skills found" now reports the resolved branch, e.g. `No skills found in vercel/next.js#canary`. - Prompt aesthetics: `exclusiveCheckbox` now uses `@inquirer/figures` (`◉`/`◯`/`❯`) and `yoctocolors-cjs` (green check, cyan description line) to match stock Inquirer checkbox look. Skill choices show the origin repo dimmed without brackets; already-installed skills are preselected instead of flagged with `[!]`. - `skills remove` parity: switched to `multiSelectExclusive` (same themed prompt), added skill description from SKILL.md on its own cyan line, dimmed composite ref instead of parenthesised plain text. Exported `readSkillMeta` from core for reuse.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git ls-remote --symref <url> HEAD(no auth, no quota). Fixesskills add vercel/next.jssilently resolving tomaininstead ofcanary, causing "no skills found".git clone(--no-checkout --depth 1 --filter=blob:none+ cone-modesparse-checkout) scoped to only the needed subtree. Drops thegigetdependency.findSkillsInReponow starts from the repo's rootskills/directory only — no full-tree walk.No skills found in vercel/next.js#canary.exclusiveCheckboxuses@inquirer/figures(◉/◯/❯) andyoctocolors-cjs(green check, cyan description line) to match stock Inquirer look. Origin dimmed without brackets; already-installed skills preselected.skills removeparity: uses the same themed prompt; shows skill description from SKILL.md on its own cyan line; dims the composite ref.Test plan
pnpm lint— 0 errorspnpm typecheck— cleanpnpm test— 202/202 passpnpm build— succeedsskills add vercel/next.jsauto-resolvescanary, shows picker with◉/◯/❯styling and descriptionsskills/subtree (not full repo)skills removeshows dimmed ref + cyan description