refactor: use kustomize overlays for ObservabilityInstaller and UIPlugin - #1206
Closed
alanconway wants to merge 2 commits into
Closed
refactor: use kustomize overlays for ObservabilityInstaller and UIPlugin#1206alanconway wants to merge 2 commits into
alanconway wants to merge 2 commits into
Conversation
Kustomize-style offline manifest generator (cmd/generator) transforms ObservabilityInstaller and UIPlugin CRs plus support files into the same resource set the operator would reconcile. - Extract common GenerateInstallerObjects, GenerateUIPluginObjects for generator and reconciler. - User secrets can be resolved offline as YAML resources or read from cluster with --cluster flag (Implemented by FallbackReader) - Parity test for output of reconciler and generator.
Replace Go struct resources with kustomize overlay building in controllers. See config/README.md for more info. Add embedded kustomize component trees under config/ for - ObservabilityInstaller (operator subscriptions and CRD instances) - UIPlugin types (dashboards, distributed-tracing, logging, troubleshooting-panel, korrel8r). Each capability is split into - operator/ (namespaces, operatorgroups, subscriptions) - resources/ (CRD instances, RBAC) directories. Parity tests verify that: - generator output matches "golden output" based on COO 1.5.1 - generator and operator output match each other.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alanconway The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedToo many files! This PR contains 125 files, which is 25 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (125)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Attempting to use github stacked PRs but they don't work from a fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Go struct resources with kustomize overlay building in controllers.
See config/README.md for more info.
Add embedded kustomize component trees under config/ for
Each capability is split into
Parity tests verify that: