Skip to content

docs(governance): add code review policy - #1730

Open
Tobi-8 wants to merge 1 commit into
rinafcode:mainfrom
Tobi-8:docs/review-policy-1599
Open

Tobi-8 wants to merge 1 commit into
rinafcode:mainfrom
Tobi-8:docs/review-policy-1599

Conversation

@Tobi-8

@Tobi-8 Tobi-8 commented Sep 28, 2026

Copy link
Copy Markdown

Summary

  • Add Governance/policies/REVIEW_POLICY.md (v1.0.0), the missing versioned reference for contribution governance. The document covers the requirements that must be met before merge (approval counts per target branch, code-owner review, CI Passed gate, DCO sign-off, resolved threads, re-approval after new commits), the review scope (what every reviewer must check, what is explicitly out of scope, and how governance-only PRs are reviewed), and the reviewer independence rule (no self-approval, two distinct reviewers on main, author cannot be the second reviewer, declared conflicts of interest, a recorded single-reviewer exception, and no bulk approvals).
  • Add a Code Review Policy entry to the policies index in Governance/README.md.
  • Scope is two files, both under Governance/; no application code, config, or dependency is touched. Where the policy overlaps CONTRIBUTING.md §9 it restates the same rules and names CONTRIBUTING.md as authoritative, matching how REVIEW_SLA.md and CONTRIBUTOR_SIGNOFF.md handle precedence.
    Testing
  • No new tests: this is a documentation-only change with no runtime behaviour, so per the policy's own "regression tests where applicable" section it adds none.
  • No existing functionality is affected: jest.config.js sets rootDir: 'src', tsconfig.build.json compiles src/, and both lint:ci and format:check glob only src//*.ts and test//*.ts — no tool in the pipeline reads Markdown, so there is no check to run for this diff.
  • Verified every relative link in the new document resolves on disk (../README.md, ../../CONTRIBUTING.md, REVIEW_SLA.md, STALE_PRS.md, CONTRIBUTOR_SIGNOFF.md, COMMUNICATION_NORMS.md, ../processes/ESCALATION_PATH.md).
  • Verified the restated approval counts and stale-approval rule against CONTRIBUTING.md §9, and git status confirms the diff touches only the two Governance/ paths.
    Closes Add a code review policy for TeachLink Backend #1599

@drips-wave

drips-wave Bot commented Sep 28, 2026

Copy link
Copy Markdown

@Tobi-8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a code review policy for TeachLink Backend

1 participant