Skip to content

[Optimization] lighthouserc.json and web-vitals are configured but no workflow runs Lighthouse #1000

Description

@RUKAYAT-CODER

Overview

lighthouserc.json sits at the repository root and web-vitals is a declared dependency consumed by src/services/webVitals.ts (which itself has 7 type errors). @lhci/cli appears in the depcheck ignore list, implying it was once used — but no workflow in .github/workflows/ invokes Lighthouse CI, and @lhci/cli is not in devDependencies. The web target is configured in app.json (web.output: "static") and bundle-size.yml does build a web bundle, so the pieces for a real web performance gate exist but are not connected.

Specifications

Features:

  • A Lighthouse CI job running against the exported web bundle
  • Budgets in lighthouserc.json enforced on pull requests
  • webVitals.ts type errors resolved so field data is actually collected

Tasks:

  • Add @lhci/cli to devDependencies and remove it from the depcheck ignore list
  • Add a Lighthouse job that reuses the expo export --platform web output already produced by bundle-size.yml
  • Review and calibrate the assertions in lighthouserc.json
  • Fix the seven type errors in src/services/webVitals.ts

Impacted Files:

  • lighthouserc.json
  • .github/workflows/bundle-size.yml
  • src/services/webVitals.ts
  • package.json

Acceptance Criteria

  • Lighthouse runs on pull requests against the web export
  • Budget violations fail the check
  • Web vitals collection type-checks

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions