Skip to content

Better: Allow to filter by sources type RD-29241#249

Open
GCorbel wants to merge 10 commits into
masterfrom
filter-type-gco
Open

Better: Allow to filter by sources type RD-29241#249
GCorbel wants to merge 10 commits into
masterfrom
filter-type-gco

Conversation

@GCorbel

@GCorbel GCorbel commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

This adds the documentation for the new type parameter for the content-sources endpoint.

@GCorbel GCorbel requested a review from FabienChaynes June 5, 2024 21:32
@GCorbel GCorbel marked this pull request as draft June 5, 2024 21:49
@GCorbel

GCorbel commented Jun 5, 2024

Copy link
Copy Markdown
Contributor Author

I mark the PR as a draft as I have some trouble with the CI

@GCorbel GCorbel force-pushed the filter-type-gco branch from b9fd1f2 to 2315d8a Compare June 6, 2024 14:22
@GCorbel GCorbel changed the base branch from master to update-go-version June 6, 2024 14:23
@GCorbel GCorbel changed the base branch from update-go-version to fix-go-version-gco June 6, 2024 14:23
@GCorbel GCorbel marked this pull request as ready for review June 6, 2024 14:25
@GCorbel GCorbel changed the base branch from fix-go-version-gco to master June 7, 2024 17:31
@GCorbel

GCorbel commented Jun 20, 2024

Copy link
Copy Markdown
Contributor Author

@jiop can you take a look at this PR ? I can't change the reviewers.

name: type
required: false
schema:
type: string

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably add an enum with the list of accepted types (like what we do for permissions).

@DrissTM

DrissTM commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

@GCorbel what's happening with this PR?

@GCorbel

GCorbel commented Mar 7, 2025

Copy link
Copy Markdown
Contributor Author

I don't have the permission to merge PRs. I take a look at the Fabien's comment.

@GCorbel

GCorbel commented Mar 7, 2025

Copy link
Copy Markdown
Contributor Author

It looks like I don't have permissio nto push a commit anymore :

ERROR: Permission to ringcentral/engage-digital-api-docs.git denied to GCorbel.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Is it possible to give me them back ?

@DrissTM

DrissTM commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

unfortunately we can't, please create a fork and open a pull request. you might have created this PR before everyone lost access to the RC org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants