Conversation
Builds dumb-init's plain C signal-forwarding executable from an upstream checkout via cibuildwheel, mirroring the manylinux+auditwheel repair upstream's own Makefile drives. Two patches backport a testing-helper fix and replicate a PyPI-only setup.py version bump that Yelp never pushed back to the v1.2.5 tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dumb-init1.2.5.post1Compiles dumb-init's standalone C signal-forwarding init executable, distributed as a
py2.py3-none-<plat>wheel. Upstream publishes no riscv64 wheel.Mirrors upstream's own
python-dists-%Makefile target: build in a manylinux container,pip wheel+auditwheel repair, done here via cibuildwheel.Differs from upstream
cp312build -setup.py's ownbdist_wheeloverride forcespy2.py3-none, so one build covers every interpreter.Testing
tests/pytest suite viaCIBW_TEST_SOURCES, stagingtesting/,VERSION,pytest.inialongside it.License: OK
Patches
0001-testing-eliminate-usage-of-pylib.patch- Backport [https://github.com/Yelp/dumb-init/commit/2c39101849abb835e9f368e3cf5c9570362a9589]. Without it,import testingfails on any pytest recent enough to no longer pull in the standalonepypackage.0002-setup.py-version-1.2.5.post1-and-drop-testing-package.patch- Inappropriate. Replicates a version bump andpackages=[]fix Yelp applied to the uploaded sdist but never pushed to the v1.2.5 tag; without it the build produces version1.2.5and ships the dev-onlytestingpackage inside the wheel.Built on cp312; CI run in progress.