Conversation
s5cmd-python-distributions repackages peak/s5cmd's own release binaries into a py3-none-<platform> wheel; its s5cmdUrls.cmake has no riscv64 entry because peak/s5cmd's goreleaser matrix (386/amd64/arm/arm64/ppc64le) stops at ppc64le. Cross-compile s5cmd from source instead with the same CGO_ENABLED=0 recipe goreleaser uses for the other platforms, repackage it into an archive matching upstream's own layout/naming, and patch s5cmdUrls.cmake to install from that local archive on riscv64 only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s5cmd0.3.3Repackages the
s5cmdS3/local-filesystem CLI binary from peak/s5cmd into a py3-none-<platform>wheel. Upstream publishes no riscv64 wheel.Mirrors the
build_wheelsjob of upstream'scd.yml.Differs from upstream
s5cmdfrom source (CGO_ENABLED=0, same ldflags as peak/s5cmd's goreleaser) instead of downloading a release archive - peak/s5cmd's own goreleaser matrix stops at ppc64le.Testing
version, localls) across the interpreter matrix.License: OK
Patches
0001-s5cmdUrls-add-riscv64-support-via-source-build.patch- Inappropriate. Adds a riscv64 branch tos5cmdUrls.cmakethat installs from the self-built local archive instead of downloading one; peak/s5cmd ships no riscv64 release asset to download.Built on cp312; passed.