Conversation
CIBW_TEST_SOURCES stages relative to cibuildwheel's invocation cwd (the
workspace root), not package-dir, so 'tests' never matched the sdist
extracted into ./pymavlink. {project}/tests in CIBW_TEST_COMMAND already
resolves against package-dir and needs no staging.
{project} expands to package-dir's parent (the whole copied cwd), not
package-dir itself; {package} is the one that maps to ./pymavlink inside
the container, so {project}/tests looked for a nonexistent workspace-root
tests directory instead of the real one.
test_trim.py and test_wp.py import pkg_resources at module level; cibuildwheel's test venv is built with --no-setuptools, so it's not present unless requested explicitly.
setuptools 82.0.0 (2026-02-08) removed pkg_resources entirely (pypa/setuptools#5007); test_trim.py/test_wp.py still import it at module level, so an unpinned setuptools resolves to a version that no longer has it.
mavutil.set_dialect() runs once at import time, picking its dialect from the MAVLINK20 env var. test_wp.py sets that var before importing mavutil, but earlier test files in the same pytest run (test_fgFDM.py etc.) import mavutil first with the var unset, caching the wrong dialect for the rest of the run. Reproducible with the real upstream wheel too - not riscv64 specific, just an ordering fragility in the test suite's module-level side effects.
--deselect's absolute-path node id (/project/pymavlink/tests/test_wp.py::...)
did not match pytest's own relative node id for the same test (pytest ran
from a different rootdir than {package}), so it silently deselected nothing.
-k with both the class and function name as required substrings reaches the
same test without colliding with test_mavparm.py's unrelated test_saveload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pymavlink2.4.49Compiles
pymavlink.dfindexer.dfindexer_cy, a small Cython/C extension for fast BIN-log offset scanning. Upstream publishes no riscv64 wheel.Mirrors upstream's
python-publish.yml(build-sdist+build-wheelsjobs), same sdist -> cibuildwheel bdist split asbuild-cffi.yml.Differs from upstream
Testing
tests/suite from the sdist against the installed wheel, plusnumpy(registry-only for riscv64) and asetuptools<82pin (pkg_resources, removed in 82) forCIBW_TEST_REQUIRES.test_mavlogdump.py,test_mavxml.py, andtest_wp.py'sRallyTest/FenceTest- they read fixture files upstream's own sdist packaging leaves out.test_wp.py::MAVWPTest::test_save- passes only when it's the first test file to importpymavlink.mavutil, since that module picks its MAVLink dialect once at import time from an env var; reproducible with the real upstream wheel too.License: OK
Built on cp312; 45 passed, 3 deselected.