Conversation
Pilot insertion callers already supply a transaction, but the internal interface also accepts pool executors. Require `ExecutorTx` to express that existing contract and document caller ownership of commit and rollback and the transaction used for related writes. Update the standard pilot and client spy. Cover insertion success and errors without opening, committing, or rolling back another transaction.
brandur
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal pilot insertion method currently accepts a general executor even though its callers already supply a transaction. This PR changes
Pilot.JobInsertManyto acceptriverdriver.ExecutorTxand documents that the caller owns commit and rollback and that related writes belong in the supplied transaction.The standard pilot and client spy adopt the signature, with coverage for preserving caller ownership on both success and error. Public insertion APIs and the other pilot method contracts retain their current behavior.