Repository navigation
Rename start_with_graceful_shutdown -> start_with_graceful_stop - #1467
Merged
Merged
Conversation
Just similar to #1456. I wish I'd noticed this earlier, but other languages don't have a function like this. I might do a quick patch release given that the crate is brand new and has no users yet.
Contributor
|
@brandur yeah I think these kinds of breaking cleanups are fair game and should be expected in any of the new ports for at least the first couple months while we clean things up. For early adopters, AI makes these breaking changes a lot less painful as long as the changelog calls them out clearly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just similar to #1456. I wish I'd noticed this earlier, but other
languages don't have a function like this. I might do a quick patch
release given that the crate is brand new and has no users yet.