Fix autocomplete for custom schemas - #613
Closed
gzxu wants to merge 1 commit into
Closed
Conversation
Autocomplete queries did not pass the River client's configured schema. With a non-default schema, job kind and queue name suggestions could query the wrong tables. Pass the configured schema to both driver queries so autocomplete reads from the same schema as the River client.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autocomplete queries for job kinds and queue names did not pass River's configured database schema. With a non-default schema, suggestions could be missing or sourced from the wrong schema.
Pass
Client.Schema()to both driver queries so autocomplete reads from the same schema as the River client.